Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify @babel/eslint-parser deps #13420

Merged
merged 1 commit into from Jun 4, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jun 3, 2021

Q                       A
License MIT

Specify dependencies on @babel/eslint-parser in @babel/eslint-shared-fixtures.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jun 3, 2021
@@ -5,6 +5,7 @@
"private": true,
"dependencies": {
"@babel/core": "workspace:^7.12.13",
"@babel/eslint-parser": "workspace:*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a private package serving as a hub of common test dependencies, so we can specify workspace:* here.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d0f2dfd:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46677/

@existentialism existentialism merged commit 4100b42 into babel:main Jun 4, 2021
@existentialism existentialism deleted the declare-eslint-fixture-deps branch June 4, 2021 01:28
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants