New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config validation message typo #13515
Fix config validation message typo #13515
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47135/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b8d5987:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
[\\"./fixtures/option-manager/babel-preset-bar\\", { | ||
\\"useSpread\\": true | ||
}] | ||
] | ||
To be a valid preset, its name and options should be wrapped in a pair of brackets" | ||
To be a valid presets, its name and options should be wrapped in a pair of brackets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it's better not to have the s
here. Maybe you could edit the checkNoUnwrappedItemOptionPairs
adding the s
for the "Maybe you meant to use" section, rather than changing it in the parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point!
I fixed it as you said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Fix config validation message typo * Fix `checkNoUnwrappedItemOptionPairs` type param
Fixed config option names in validation message
preset
/plugin
->presets
/plugins
.