New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue to allow module block in member expression #13573
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47410/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1c04552:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker: After this PR, we can further remove the module
lookahead. Like how we are handling async function
and async x =>
, we can parse the module
as an id
and when we see a left curly brace, we can reuse the id
node and then finished as a ModuleExpression
.
Can you delete the |
@nicolo-ribaudo done. I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The CI error is unrelated and has been fixed in #13567. |
* Accept module in primaryExpression * Add module blocks to primaryExpression * Fix package.json * Fix yarn.lock * Fix yarn.lock * Remove package.tgz file
Moved the logic to check for
module {}
in babel-parser fromParser#parseMaybeUnary
toParser#parseExprAtom
within thett.name
token.