Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable class static blocks by default #13713

Merged
merged 6 commits into from Oct 28, 2021

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Aug 30, 2021

Q                       A
Minor: New Feature? Y
Tests Added + Pass? Yes
Documentation PR Link babel/website#2571
Any Dependency Changes? N
License MIT

@rbuckton is going to ask for Stage 4 at next meeting(agenda).
if the feature gets Stage 4, we can merge this PR?

@sosukesuzuki sosukesuzuki added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser pkg: preset-env Spec: Class Static Block labels Aug 30, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 30, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2886a6e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 30, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49473/

@fedeci fedeci added this to the v7.16.0 milestone Aug 30, 2021
@nicolo-ribaudo
Copy link
Member

Marking as "Do not merge" until Stage 4 is confirmed.

@JLHwung
Copy link
Contributor

JLHwung commented Aug 31, 2021

@rbuckton
Copy link

Stage 4 confirmed :)

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Sep 1, 2021
@JLHwung JLHwung force-pushed the enable-static-blocks-in-default branch from 7a17f8d to 2886a6e Compare October 28, 2021 18:21
@JLHwung JLHwung merged commit ddc45a5 into babel:main Oct 28, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Class Static Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants