New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow #a in #b in c
and similar expressions
#13727
Disallow #a in #b in c
and similar expressions
#13727
Conversation
nicolo-ribaudo
commented
Sep 2, 2021
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Fixes #13726 |
Patch: Bug Fix? | |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48524/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7779a6c:
|
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Can you add a new test case? class C {
#x;
async test() {
await #x in this
}
} It was parsed successfully but should throw, probably fixed in this PR. |
@@ -504,7 +531,7 @@ export default class ExpressionParser extends LValParser { | |||
const startLoc = this.state.startLoc; | |||
|
|||
return this.parseExprOp( | |||
this.parseMaybeUnary(), | |||
this.parseMaybeUnaryOrPrivate(), |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.