New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve transform-react-jsx typings #13820
Merged
JLHwung
merged 7 commits into
babel:main
from
JLHwung:improve-transform-react-jsx-typings
Oct 7, 2021
Merged
Improve transform-react-jsx typings #13820
JLHwung
merged 7 commits into
babel:main
from
JLHwung:improve-transform-react-jsx-typings
Oct 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Spec Compliance 👓
A type of pull request used for our changelog categories
PR: Internal 🏠
A type of pull request used for our changelog categories
labels
Oct 6, 2021
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49085/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c487241:
|
JLHwung
force-pushed
the
improve-transform-react-jsx-typings
branch
from
October 6, 2021 13:41
db5f158
to
cca951b
Compare
JLHwung
removed
the
PR: Spec Compliance 👓
A type of pull request used for our changelog categories
label
Oct 6, 2021
nicolo-ribaudo
approved these changes
Oct 6, 2021
hzoo
reviewed
Oct 7, 2021
hzoo
approved these changes
Oct 7, 2021
Co-authored-by: Henry Zhu <hi@henryzoo.com>
JLHwung
commented
Oct 7, 2021
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Jan 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Internal 🏠
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts by improving typings of
transform-react-jsx
, the type checker catches unreachable statements inbabel/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts
Lines 95 to 103 in 58a65e9
The guard should have been
!attr.isJSXAttribute()
. However, since we have already thrownselfSourceError
in automatic runtimebabel/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts
Line 692 in 58a65e9
and we allow multiple
__self
and__source
in classical runtime. I think current behavior is ok so we can simply remove the unreachable statements.This PR also exports a
PluginPass
type from@babel/core
, which can be used by plugin authors.