Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: remove ineffectual helper names filter #13841

Merged
merged 1 commit into from Oct 12, 2021

Conversation

lightmare
Copy link
Contributor

@lightmare lightmare commented Oct 11, 2021

Q                       A
Fixed Issues? none
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Property __esModule is not enumerable, so it won't appear in Object.keys. If it did, the filter that was there wouldn't see it because it ran after one leading _ was removed ;)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2bf3a9:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49189/

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Oct 12, 2021
@JLHwung JLHwung merged commit 2403a48 into babel:main Oct 12, 2021
@lightmare lightmare deleted the minor-remove-helper-name-filter branch October 12, 2021 19:19
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants