[ts] precise return type on createTypeAnnotationBasedOnTypeof (babel-types)
#13844
+32
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... return type based on argument value
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8156bf5:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49206/ |
existentialism
approved these changes
Oct 14, 2021
existentialism
added
pkg: types
PR: Internal 🏠
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff best viewed ignoring whitespace changes, it'll show more clearly that only the function type is changed to be more granular — instead of a union argument type and a union return type, the argument now selects the return type. Remaining changes are just rewriting
if-elsechain to aswitch.