New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't transform declare class
in plugin-proposal-class-properties
#13854
Don't transform declare class
in plugin-proposal-class-properties
#13854
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9578e3e:
|
packages/babel-helper-create-class-features-plugin/src/index.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49238/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we throw an error, but plugin ordering is the hardest part of Babel's architecture so 🤷
@nicolo-ribaudo yeah, I struggled with figuring out how to get the plugin ordering just right and i've left a note: #13853 (comment) . Hopefully a future version of babel can manage plugin+preset ordering in a better way. Maybe something as simple as printing the effective config when an error like this is thrown. |
In the
Class
visitor,has been added.
Also some typescript improvements in the typescript transform.