Recover from shorthand assign exprs #13968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Polish 💅
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8f55f57:
|
nicolo-ribaudo
approved these changes
Nov 19, 2021
| this.classScope.usePrivateName(this.state.value, this.state.start); | ||
| node.property = this.parsePrivateName(); | ||
| } else { | ||
| node.property = this.parseIdentifier(true); |
There was a problem hiding this comment.
Thanks for refactoring all of this to be more readable 😄
existentialism
approved these changes
Nov 19, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
({ x = 1 })(could be an unfinished arrow head)Currently Babel throws unexpected token when parsing
({ x = 1 }).We could recover in this case. It will be parsed as an assignment pattern under object property. This approach aligns to how we handle other errors such as
doubleProtoandprivateKey.The error message/code is copied from V8.
Also included some tweaks.