Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only bundle the release build, and don't import src in tests #13978

Merged
merged 4 commits into from Nov 24, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 18, 2021

Q                       A
License MIT

This is extracted from #13966.
With this PR, we:

  • only bundle (the packages that we currently bundle) when creating the release build. This aligns make build with make watch for local development.
  • for bundled packages, run tests using files from lib rather than src. We must now skip these tests on the production build, but we were effectively already not testing the production bundle (because we were re-compiling src on the fly)

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 18, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49913/

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review November 19, 2021 00:03
@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 19, 2021
@nicolo-ribaudo
Copy link
Member Author

The last commit does #13966 (comment), with an extension that clearly indicates that those test files are skipped when publishing.

@JLHwung JLHwung merged commit ad1798e into babel:main Nov 24, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the only-bundle-production branch November 24, 2021 19:32
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: publishing process area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants