Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintain estree string literal shape when cloned #14039

Merged
merged 1 commit into from Dec 9, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 9, 2021

Q                       A
Fixed Issues? Fixes #14037
Patch: Bug Fix? Y
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Override cloneStringLiteral to maintain ESTree string literal shape.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression area: estree labels Dec 9, 2021
@@ -1,3 +0,0 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test options is moved to upper level module-string-names/options.json so it can be shared with the other test case.

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 9, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50230/

@JLHwung JLHwung merged commit 3908049 into babel:main Dec 9, 2021
@JLHwung JLHwung deleted the fix-14037 branch December 9, 2021 22:58
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: estree i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected StringLiteral node in @babel/eslint-parser
4 participants