Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow $schema property in json config files #14067

Merged
merged 2 commits into from Dec 29, 2021
Merged

Allow $schema property in json config files #14067

merged 2 commits into from Dec 29, 2021

Conversation

The-x-Theorist
Copy link
Contributor

@The-x-Theorist The-x-Theorist commented Dec 20, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #14038
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

$schema property will be deleted from json config files, while file is being read.

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 20, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50436/

@nicolo-ribaudo nicolo-ribaudo changed the title Fix: Error on property in json config files Allow $schema property in json config files Dec 20, 2021
@nicolo-ribaudo nicolo-ribaudo added the PR: Polish 💅 A type of pull request used for our changelog categories label Dec 20, 2021
JLHwung
JLHwung approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit 2c68d03 into babel:main Dec 29, 2021
@The-x-Theorist The-x-Theorist deleted the schema-property-json-config branch December 29, 2021 05:45
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2022
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@arthurfiorette arthurfiorette arthurfiorette approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Babel is throwing an error at the $schema property in json config files
5 participants
@The-x-Theorist @babel-bot @JLHwung @nicolo-ribaudo @arthurfiorette