Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser support for the "regexp unicode sets" proposal #14086

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 30, 2021

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link babel/website#2625
Any Dependency Changes?
License MIT

This implements parser support for https://github.com/tc39/proposal-regexp-set-notation/. Actually, most of the work was done in jviereck/regjsparser#113 and we just need to update @babel/parser to accept the v flag.

The proposal is the result of merging two proposals, and it's name is quite long (RegExp set notation + properties of strings). I used regexpUnicodeSets flag as the parser plugin name because the v flag is called unicodeSets.

I'll merge this PR to a feature branch so that I can then open another one to create the transform plugin (based on https://github.com/mathiasbynens/regexpu-core/). I have already done most of the work in the various regexp packages, we only need to wire it to Babel.

cc @mathiasbynens

@nicolo-ribaudo nicolo-ribaudo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Dec 30, 2021
@nicolo-ribaudo nicolo-ribaudo added this to the v7.17.0 milestone Dec 30, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50478/

@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to feat-7.17.0/regexp-unicode-sets December 30, 2021 23:01
@nicolo-ribaudo nicolo-ribaudo merged commit 9a41623 into babel:feat-7.17.0/regexp-unicode-sets Dec 31, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the parser-regexp-unicode-sets branch December 31, 2021 17:44
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants