fix: forward stop signal to parent path #14105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we extract
traverse.node
into a new routinetraverseNode
that returns whether the traversal stops early. Becausetraverse.node
is an API,traverse.node
now callstraverseNode
but returnsundefined
conditionally.path.visit()
now callstraverseNode
and set.shouldStop
accordingly when the traversal is requested to stop.For example,
has AST
when an Identifier visitor requests to stop by calling
path.stop()
, the signal is not forwarded toExpressionStatement[]
queue visitor because we simply calledtraverse.node()
which lost track of whether the traversal stopped gracefully, so the root traversal continues tog;
.