New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the transform of super.foo--
/super[foo]--
(and prefix)
#14162
Conversation
magic-akari
commented
Jan 16, 2022
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Fixes #14161 |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
super.foo--
/super[foo]--
/--super.foo
/--super[foo]
/super.foo--
/super[foo]--
/--super.foo
/--super[foo]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Not related to this PR, but we need to add logical assignment support to super property transforms (they should have been extracted to a new helper):
class A extends B {
async foo() {
super.foo ??= 1;
}
}
super.foo--
/super[foo]--
/--super.foo
/--super[foo]
super.foo--
/super[foo]--
(and prefix)
I slightly reworded the PR title to fit in a commit message |
I am willing to fix it .Should I open a new issue? |