Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect in parsing in arrow ConciseBody #14194

Merged
merged 1 commit into from Jan 21, 2022
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 21, 2022

Q                       A
Fixed Issues? Fixes #14193
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR fixes a regression introduced at #11930, where I mistyped tt.braceL as tt.bracketL. A new regression test has been added.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser labels Jan 21, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50859/

@nicolo-ribaudo nicolo-ribaudo changed the title fix: incorrect conciseBody lookahead fix: incorrect in parsing in arrow ConciseBody Jan 21, 2022
@JLHwung JLHwung merged commit e5d29f6 into babel:main Jan 21, 2022
@JLHwung JLHwung deleted the fix-14193 branch January 21, 2022 23:27
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fails to parse Valid JS in specific scenario invloving ArrowExpression and BinaryExpression
4 participants