New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compat data (specifically for rhino 1.7.14) #14208
Conversation
Uh, it's because of #14181 / compat-table/compat-table#1784. We'll handle that issue soon-ish, but for now you can edit babel/packages/babel-compat-data/scripts/data/plugin-features.js Lines 158 to 164 in b1e79de
"static class fields" ):
"static class fields, public static class fields",
"static class fields, private static class fields",
"static class fields, computed static class fields" |
Huh, that doesn't seem to have addressed either the test failure or the extraneous |
It didn't work because the separator is |
Perfect, thank you. That appears to have worked correctly. I didn't commit the changes to plugin-features.js as I assume those are temporarily required only. |
Oh please commit them, so that the committed script always reflects the committed data. |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50936/ |
Done. Thanks for the help. |
"static class fields", | ||
"static class fields / public static class fields", | ||
"static class fields / private static class fields", | ||
"static class fields / computed static class fields", | ||
"instance class fields, public instance class fields", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open another PR changing ,
to /
here. I'd prefer to keep it separate because it might cause changes to our compat data and fixtures not related to rhino.
This is a first attempt at updating compat data, in this case specifically to support rhino 1.7.14. Per discussion over at mozilla/rhino#1164 with @nicolo-ribaudo, I updated the fixtures as well with
make build-compat-data && make bootstrap && OVERWRITE=true yarn jest
. Unfortunately, this seems to have triggered a number of unrelated changes to the fixturestdout
files and caused one of the fixture tests to fail:Curious for any advice you all have as to how to resolve these. I'm sure I'm doing something wrong here.