Fix reinstantiation of inherited plugins #14241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51170/ |
nicolo-ribaudo
force-pushed
the
bug-14233
branch
from
bddda1c
to
8f546c1
Compare
nicolo-ribaudo
added
i: regression
pkg: core
PR: Bug Fix 🐛
nicolo-ribaudo
changed the title
JLHwung
approved these changes
Feb 7, 2022
existentialism
approved these changes
Feb 7, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot always push the inherited external dependencies into a plugin's external dependencies, because if the "derived" plugin ìs cached it's dependencies array is frozen.
This PR fixes it by "joining" the two dependency lists into a new array, and moves the freeze earlier in the process so that TS would have caught this bug (because the array is now always frozen at that point, rather than just sometimes).