Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import type/typeof printing with no specifiers #14309

Merged
merged 2 commits into from Feb 28, 2022

Conversation

The-x-Theorist
Copy link
Contributor

@The-x-Theorist The-x-Theorist commented Feb 25, 2022

Q                       A
Fixed Issues? Fixes #14250
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Empty braces will still be printed even if the there are no specifers, check added for importKind, empty braces will be printed on type and typeof imports.

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 25, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51374/

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Feb 25, 2022
@nicolo-ribaudo nicolo-ribaudo changed the title Fix: no empty with braces with zero specifiers Fix import type/typeof printing with no specifiers Feb 25, 2022
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I rebased to fix the CI failure and pushed a commit to deduplicate some code (keeping the logic you implemented: it was correct, but two branches could be merged).

@nicolo-ribaudo nicolo-ribaudo merged commit 4f80693 into babel:main Feb 28, 2022
@The-x-Theorist The-x-Theorist deleted the empty-specifiers-bug branch March 1, 2022 11:12
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: import type {} from 'some-module' results in invalid typescript
4 participants