fix: support bigints in update expressions for private fields #14311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
magic-akari
commented
Feb 26, 2022
•
magic-akari
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #14302 |
| Patch: Bug Fix? | 👍 |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
JLHwung
added
PR: Bug Fix 🐛
| @@ -43,5 +43,19 @@ class Cl { | |||
|
|
|||
| this.#privateFieldValue = -(this.#privateFieldValue ** this.#privateFieldValue); | |||
| this.publicFieldValue = -(this.publicFieldValue ** this.publicFieldValue); | |||
|
|
|||
| this.#privateField = 0n; | |||
There was a problem hiding this comment.
Can you split this new test into a new one (updates-bigint) and add "minNodeVersion": "10.0.0" to its options.json file? Because older versions don't support bigints.
nicolo-ribaudo
approved these changes
Feb 27, 2022
nicolo-ribaudo
changed the title
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.