Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate exports initialization with many exports #14313

Merged
merged 1 commit into from Feb 27, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 27, 2022

Q                       A
Fixed Issues? Fixes #14272, closes #14276
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is just #14276 with a new test. I couldn't push to that PR, probably because it was opened from the main branch of the fork.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: modules labels Feb 27, 2022
@nicolo-ribaudo nicolo-ribaudo changed the title Fix duplicate exports initialization with many exports (#14272) Fix duplicate exports initialization with many exports Feb 27, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Feb 27, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51379/

@nicolo-ribaudo
Copy link
Member Author

This has already been reviewed at #14276.

@nicolo-ribaudo nicolo-ribaudo merged commit 2671c98 into babel:main Feb 27, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the JasinYip/main branch February 27, 2022 01:54
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: modules outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: initializing ES Module exports might leads JSC to "Maximum call stack size exceeded"
3 participants