Fix update expression for exported bigints #14341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
area: modules
PR: Bug Fix 🐛
| @@ -20,73 +16,6 @@ export default function simplifyAccess(path: NodePath, bindingNames) { | |||
| } | |||
|
|
|||
| const simpleAssignmentVisitor = { | |||
| UpdateExpression: { | |||
There was a problem hiding this comment.
If someone accidentally updates @babel/helper-simple-access without also updating @babel/helper-module-transforms (this is a valid thing to do, according to the semver dependency versions), I fear that this will break their current code.
There was a problem hiding this comment.
Yes.
What can I do? Should I bump the version of the package?
There was a problem hiding this comment.
No, because we keep all the versions synchronized (and it would require a major bump).
It's annoying, but a solution until Babel 8 is to pass a includeUpdateExpression: boolean = true option to simplifyAccess, and only skip the UpdateExpression visitor when that option is set to false.
nicolo-ribaudo
approved these changes
Mar 10, 2022
JLHwung
approved these changes
Mar 10, 2022
nicolo-ribaudo
changed the title
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/helper-simple-accesschanged