New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused @babel/helpers
code
#14343
Merged
nicolo-ribaudo
merged 6 commits into
babel:main
from
nicolo-ribaudo:helpers-minor-refactor
Mar 23, 2022
Merged
Remove unused @babel/helpers
code
#14343
nicolo-ribaudo
merged 6 commits into
babel:main
from
nicolo-ribaudo:helpers-minor-refactor
Mar 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
A type of pull request used for our changelog categories
label
Mar 9, 2022
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51453/ |
- When using `@babel/runtime`, we don't need the metadata so we can skip computing it - This fixes a Babel 8 bug introduced in the prev commit, because FileClass is not initialized when not using inline helpers
It's just nicer, side effects in getters are surprising.
nicolo-ribaudo
force-pushed
the
helpers-minor-refactor
branch
from
March 9, 2022 23:45
377aec0
to
2b2f58a
Compare
nicolo-ribaudo
force-pushed
the
helpers-minor-refactor
branch
from
March 9, 2022 23:46
2b2f58a
to
51439df
Compare
JLHwung
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
existentialism
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Jun 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Internal 🏠
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2
traverse
call that we used to get the program path from aFile
(review this with whitespaces diff disabled)if (!process.env.BABEL_8_BREAKING)
and slightly improves the related types@babel/core
versions