New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow variable and function with the same name in static blocks #14344
Conversation
…claration in class static block babel#14257
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51459/ |
I wonder why babel bot shows another issue (not about static block) in REPL... |
You can edit the REPL contents to whatever you want 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failure is not related to this PR, it's a flaky test that sometimes fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static block is an ES2022 feature, can you move the test case to es2022? There is a static block folder over there. I think it suffices to add only one test case.
I have created a new subdirectory: |
packages/babel-runtime-corejs3/helpers/esm/possibleConstructorReturn.js
Outdated
Show resolved
Hide resolved
...ser/test/fixtures/es2022/class-private-names-duplicated/static-block-duplicate-name/input.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Allow a variable and a function to have a same name in a static block