Transform await in computed class keys

[Yokubjon-J]

Q	A
Fixed Issues?	Fixes #14347
Patch: Bug Fix?	Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52376/

[Yokubjon-J]

I have modified package.json files (of 2 packages) by adding the necessary dependencies and I think this is why build-standalone and other tests are failing (and I see The lockfile would have been modified by this install, which is explicitly forbidden. warning).
However, even after I have these modifications, the output file is still producing the same error.
I'd like to hear your thoughts about it.

[liuxingbaoyu]

It seems that you need to run the yarn command in the root directory and then commit the .lock file.

[Yokubjon-J]

@liuxingbaoyu wow I have noticed your comment after 20 days since you commented (unfortunately)!
Thank you very much, I am going to try it!

[liuxingbaoyu]

Can you do a rebase?
Also when you think it can be reviewed, please mark it as ready.

[Yokubjon-J]

I tried to rebase draft-14347 on main, but I am getting an error:

Auto-merging packages/babel-plugin-proposal-async-generator-functions/package.json
Auto-merging packages/babel-plugin-proposal-async-generator-functions/src/index.ts
CONFLICT (content): Merge conflict in packages/babel-plugin-proposal-async-generator-functions/src/index.ts
error: could not apply 6548c38378... environmentVisitor merged but issue still persists

To resolve the conflict, I ran git add . then git commit -am "commit all" but I got another error:
ESLint couldn't find the plugin "@babel/eslint-plugin-development".
I would like to know your advice on how to proceed forth.
Here is the screenshot of the last error in full:

[nicolo-ribaudo]

We lint Babel using Babel itself, so you need to compile (make build) before committing. Or you can use git commit -am "commit all" --no-verify to skip linting.

[nicolo-ribaudo]

@Yokubjon-J It looks like something went wrong when rebasing, do you need any help?

[Yokubjon-J]

@nicolo-ribaudo Thank you, I would be very happy!
I wanted to update my branch (draft-14347) with the main branch while retaining my commits. But I got some conflicting commits and make build also threw errors. Some of the files were damaged like so; make bootstrap and make build stopped generating lib folder in babel-plugin-proposal-async-generator-functions.

[Yokubjon-J]

What I wanted to do with rebase is update my branch draft-14347 with main.

[liuxingbaoyu]

Great, CI all passed.

[Yokubjon-J]

Oh I thank you very much @nicolo-ribaudo! It was so fast! I thought it would be a complicated process. Now I am going to work on the issue of the bug.

[nicolo-ribaudo]

@Yokubjon-J If you also need help with downloading the updated branch, you probably have to do something like this:

git fetch
git reset origin/draft-14347 --hard

[Yokubjon-J]

Even though environmentVisitor is merged in
https://github.com/Yokubjon-J/babel/blob/draft-14347/packages/babel-plugin-proposal-async-generator-functions/src/index.ts#L27
and
https://github.com/Yokubjon-J/babel/blob/draft-14347/packages/babel-plugin-proposal-async-generator-functions/src/index.ts#L68
and also in
https://github.com/Yokubjon-J/babel/blob/draft-14347/packages/babel-helper-remap-async-to-generator/src/index.ts#L35
I am anyway getting a wrong output.
I would be glad to know your suggestions on this.

[nicolo-ribaudo]

@Yokubjon-J The reason why it's not working is because we are still doing Function(path) { path.skip(); }. A class method is a function, so we are skipping the whole method (including its key). It's probably enough to just delete that Function visitor, since environmentVisitor will take care of that.

[nicolo-ribaudo]

Actually, we probably still need to manually skip ArrowFunctionExpression because environmentVisitor does not skip them.

[Yokubjon-J]

I think I am getting errors because I forgot to run make test, I am now running them and once complete I am going to push the changes.

[nicolo-ribaudo]

Can you run yarn && yarn dedupe again and commit the updated yarn.lock file?

[nicolo-ribaudo]

Thanks!

[Yokubjon-J]

@nicolo-ribaudo Thank you a lot! I have learned so much! Especially getting to know that class methods (inside classes) are treated as function methods was insightful!

[nicolo-ribaudo]

Hey, no need to keep this up to date with main! I'm just waiti f for a second review.

[liuxingbaoyu]

Generally, rebasing is only required after there have been a lot of changes in the main branch.
Also in PR we should use rebase instead of merge.

[Yokubjon-J]

@liuxingbaoyu I am afraid of rebasing for the fear of getting that problem again :)

[liuxingbaoyu]

This is normal, I screwed everything up the first time I did the rebase.
If you use VS CODE, you can use the gitlens plugin, which is very convenient.