Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing semicolons in 2021-12 decorators output #14398

Merged
merged 1 commit into from Mar 28, 2022
Merged

Add missing semicolons in 2021-12 decorators output #14398

merged 1 commit into from Mar 28, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 28, 2022 •
edited by gitpod-io bot

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Polish 💅 A type of pull request used for our changelog categories Spec: Decorators labels Mar 28, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51583/

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Mar 28, 2022 •
edited

@JLHwung It looks like your PR didn't fix the timeout 😕

@JLHwung
Copy link
Contributor

JLHwung commented Mar 28, 2022

@nicolo-ribaudo Yeah, it seems that at times the watcher spend more than 2 seconds to set up. Maybe we should fallback to a polling approach.

@nicolo-ribaudo nicolo-ribaudo merged commit 611f5c8 into babel:main Mar 28, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the decorators-missing-semi branch March 28, 2022 20:34
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request May 21, 2022
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories Spec: Decorators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @existentialism