New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove git.io shortlinks from repo #14493
Remove git.io shortlinks from repo #14493
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51758/ |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51747/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace master
to main
?
Sure, I'll update the PR later today. The current URL's are just what the existing git.io links resolved to. |
}, | ||
}, | ||
classProperties: { | ||
syntax: { | ||
name: "@babel/plugin-syntax-class-properties", | ||
url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties", | ||
url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL returns 404.
}, | ||
}, | ||
classPrivateProperties: { | ||
syntax: { | ||
name: "@babel/plugin-syntax-class-properties", | ||
url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties", | ||
url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL returns 404.
}, | ||
}, | ||
classPrivateMethods: { | ||
syntax: { | ||
name: "@babel/plugin-syntax-class-properties", | ||
url: "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-class-properties", | ||
url: "https://github.com/babel/babel/tree/main/packages/babel-plugin-syntax-class-properties", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL returns 404.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URLs returning 404 are archived plugins, we can fix them in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I agree, lets get this merged since it's quite urgent. We can iterate and improve the links later.
Github has deprecated git.io and will be disabling all links on April 29th.
This PR replaces all git.io shortened links with the URL they redirect to.