enable noImplicitAny #14601

JLHwung · 2022-05-26T13:08:15Z

Q	A
License	MIT

This is a meta PR tracking the progress of the noImplicitAny option adoption. I will mark the PR as ready when CI is green.

babel-bot · 2022-05-26T13:32:02Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52321/

liuxingbaoyu · 2022-05-30T18:36:22Z

@JLHwung Are you writing babel-template and babel-core, if not I would like to give it a try.

nicolo-ribaudo · 2022-06-11T14:53:39Z

packages/babel-types/package.json

@@ -25,7 +25,7 @@
  },
  "dependencies": {
    "@babel/helper-validator-identifier": "workspace:^",
-    "to-fast-properties": "^2.0.0"
+    "to-fast-properties": "condition:BABEL_8_BREAKING ? ^4.0.0 : ^2.0.0"


v4 is native ESM, that we can't use yet because we compile to CJS. We should downgrade to v3.

🤔 Aren't we gonna make Babel 8 ESM-only?

Yes, but it's not ready yet so the current Babel 8 build fails with this PR 😛

We will be able to upgrade before Babel 8.0.0, but not yet.

* preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* enable noImplicitAny * codemod (#14602) * Improve preset/plugin-typescript typings (#14603) * preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve transform-runtime typings Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* improve helper-function-name typings * helper hoist variables * helper-member-expression-to-functions * helper-simple-access * remap-async-to-generator * helper-annotate-as-pure * helper-builder-binary-assignment-operator-visitor * helper-check-duplicate-nodes * early return when export declaration is export all * split-export-declaration * helper-define-map * define-map * Update packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * review comments Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* refactor: simplify ImportInjector._applyDefaults * helper-module-imports * map globals to the one used in Babel 8

* plugin-test-runner * fixture-test-runner * Update packages/babel-helper-fixtures/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* refactor: move shipped-proposals to ts * preset-env * address review comments

* refactor: simplify buildOptimizedSequenceExpression * proposal-pipeline-operator * address review comments

* babel-standalone * address review comment

* change AssumptionFunction return type * helper-create-regexp-features-plugin * create-class-features-plugin * transform-for-of * improve unicode-escapes typings * transform-object-super * transform-react-constant-elements * proto-to-assign * function-name * flow-comments TS cannot infer Flow visitor type because we have both Flow type and Flow virtual type.

* code-frame * map js-tokens to Babel 8 * highlight

* bump to-fast-properties to v4 * types * mark node comments as mutable

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* generator * refactor: merge {start,end}Terminatorless to printTerminatorless * inline buildYieldAwait * inline ExportDeclaration * also export Pos * let getPossibleRaw return string | void * Apply suggestions from code review Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com> * address review comments * do not export internal printer method * simplify needsWhitespace Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>

* exponentiation-operator * duplicate-keys * computed-properties * replace-supers * block-scoping * block-scoped-functions * syntax-typescript * record-and-tuple * private-property-in-object * partial-application * json-strings * function-sent * function-bind * class-static-block * async-generator-functions * Update packages/babel-plugin-transform-block-scoping/src/index.ts * address review comments * helper-replace-supers

* external-helpers * bugfix * transform-parameters * object-rest-spread * destructuring-private * transform-destructuring * proposal-decorators * optional-chaining * helper-wrap-function * explode-assignable-expression * helper-compilation-targets * helper-plugin-utils * helpers * helper-validator-option * fix: allow "+" and "-" in MappedType .readonly/.optional * fixture-test-runner * remove charcodes from dependencies the charcodes transform will inline charCodes.* so we can remove it from dependencies

* export removeProperties options * traverse * fix other packages typings * fix gatherNodeParts * downgrade to-fast-properties to v3 * fix typo * babel-core/normalize-file * add ignore comment property used by flow plugin * refine getLastStatement typings * fix babel-standalone rebase typing error * fix assert.rejects polyfill * simplify _param typings * supress Babel 7 AST errors * loosen defineType typings The AST typings are generated from defineType calls, so defineType should accept a string as type. * restore legacy code * Suppress data/core-js-compat importing errors

nicolo-ribaudo

Disclaimer: I only reviewed this quickly, but I already reviewed all the commits in their PRs.

JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label May 26, 2022

JLHwung mentioned this pull request May 26, 2022

Improve codemod typings #14602

Merged

JLHwung force-pushed the noImplicitAny branch from 86cf737 to 2702dfc Compare May 26, 2022 13:29

JLHwung mentioned this pull request May 26, 2022

Improve preset/plugin-typescript typings #14603

Merged

JLHwung added the umbrella ☂️ label May 26, 2022

JLHwung mentioned this pull request May 26, 2022

Improve transform-runtime typings #14605

Merged

JLHwung force-pushed the noImplicitAny branch from d35b759 to 5b61901 Compare May 26, 2022 19:34

This was referenced May 26, 2022

improve jsx packages typings #14607

Merged

Improve module transform packages typings #14608

Merged

Improve @babel/helper-* typings #14620

Merged

This was referenced May 30, 2022

improve babel-template typings #14621

Merged

Improve babel-core typings #14622

Merged

JLHwung mentioned this pull request Jun 8, 2022

Improve traverse typings #14648

Merged

nicolo-ribaudo reviewed Jun 11, 2022

View reviewed changes

JLHwung force-pushed the noImplicitAny branch 2 times, most recently from bceef21 to 18291cb Compare June 21, 2022 02:35

enable noImplicitAny

1ee71c2

JLHwung and others added 20 commits June 21, 2022 11:48

Improve preset/plugin-typescript typings (#14603)

ee06d12

* preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

jsx (#14607)

7623b47

Improve module transform packages typings (#14608)

000086d

improve babel-template typings (#14621)

88378e2

improve helper-module-imports typings (#14623)

a32418b

* refactor: simplify ImportInjector._applyDefaults * helper-module-imports * map globals to the one used in Babel 8

Improve fixture-test-runner typings (#14625)

7456f50

* plugin-test-runner * fixture-test-runner * Update packages/babel-helper-fixtures/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

Improve preset-env typings (#14606)

54e2e60

* refactor: move shipped-proposals to ts * preset-env * address review comments

Improve pipeline-operator typings (#14629)

143bf36

* refactor: simplify buildOptimizedSequenceExpression * proposal-pipeline-operator * address review comments

improve standalone typings (#14630)

77e5aea

* babel-standalone * address review comment

Improve code-frame/hightlight typings (#14643)

ff7fe9a

* code-frame * map js-tokens to Babel 8 * highlight

Improve @babel/types typings (#14645)

00eaf46

* bump to-fast-properties to v4 * types * mark node comments as mutable

Improve babel-core typings (#14622)

93ff5c3

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

improve transform-classes typings (#14624)

951e8e6

JLHwung force-pushed the noImplicitAny branch from 03880bf to 5d923a3 Compare June 21, 2022 15:49

JLHwung marked this pull request as ready for review June 21, 2022 15:49

liuxingbaoyu approved these changes Jun 21, 2022

View reviewed changes

JLHwung requested a review from nicolo-ribaudo June 21, 2022 17:57

nicolo-ribaudo approved these changes Jun 21, 2022

View reviewed changes

JLHwung merged commit b1e73d6 into main Jun 21, 2022

JLHwung deleted the noImplicitAny branch June 21, 2022 20:03

JLHwung mentioned this pull request Aug 26, 2022

Fix helper-builder-react-jsx compat with Babel 7.9 #14886

Merged

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 21, 2022

github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable noImplicitAny #14601

enable noImplicitAny #14601

JLHwung commented May 26, 2022 •

edited by gitpod-io bot

babel-bot commented May 26, 2022 •

edited

liuxingbaoyu commented May 30, 2022

nicolo-ribaudo Jun 11, 2022

JLHwung Jun 11, 2022

nicolo-ribaudo Jun 11, 2022

nicolo-ribaudo left a comment

enable noImplicitAny #14601

enable noImplicitAny #14601

Conversation

JLHwung commented May 26, 2022 • edited by gitpod-io bot

babel-bot commented May 26, 2022 • edited

liuxingbaoyu commented May 30, 2022

nicolo-ribaudo Jun 11, 2022

Choose a reason for hiding this comment

JLHwung Jun 11, 2022

Choose a reason for hiding this comment

nicolo-ribaudo Jun 11, 2022

Choose a reason for hiding this comment

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

JLHwung commented May 26, 2022 •

edited by gitpod-io bot

babel-bot commented May 26, 2022 •

edited