Fix named destructuring exports #14655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52188/ |
|
What is the output before this PR? |
liuxingbaoyu
approved these changes
Jun 10, 2022
underfin
commented
Jun 10, 2022
| ({ | ||
| foo: bar, | ||
| baz | ||
| } = {}), _export("baz", baz); |
There was a problem hiding this comment.
@nicolo-ribaudo before this pr, will not export baz
underfin
commented
Jun 10, 2022
| @@ -190,7 +190,7 @@ export default declare<PluginState>((api, options: Options) => { | |||
| return; | |||
| } | |||
| const exportedNames = this.exports[name]; | |||
| if (!exportedNames) return; | |||
| if (!exportedNames) continue; | |||
| for (const exportedName of exportedNames) { | |||
There was a problem hiding this comment.
If here not find matched export name, here will go out of function. The other names will not add to export.
liuxingbaoyu
added
the
PR: Bug Fix 🐛
nicolo-ribaudo
changed the title
|
@JLHwung Can you publish a new version for this? Thanks :) |
|
Ok, doing it now. |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ructuring object
Fixes #1, Fixes #2