Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parser] Make decoratorsBeforeExport default to false #14695

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 26, 2022

Q                       A
Minor: New Feature? Y
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Ref #12712 (comment)

It already defaults to false in the transform plugin and in the generator.

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser Spec: Decorators labels Jun 26, 2022
@nicolo-ribaudo nicolo-ribaudo added this to the 7.19.0 milestone Jun 26, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 26, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52719/

@nicolo-ribaudo nicolo-ribaudo added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release ⚠️ Do not merge and removed ⚠️ Do not merge labels Jun 27, 2022
@nicolo-ribaudo nicolo-ribaudo force-pushed the parser-default-decoratorsBeforeExport branch from ffec2c6 to 942c580 Compare August 16, 2022 13:05
@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to feat-7.19.0/decorators August 16, 2022 13:06
@nicolo-ribaudo nicolo-ribaudo merged commit db8cf71 into babel:feat-7.19.0/decorators Aug 16, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the parser-default-decoratorsBeforeExport branch August 16, 2022 13:08
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Aug 17, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Decorators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants