Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to hash syntax for Record&Tuple #14744

Merged
merged 2 commits into from Sep 2, 2022
Merged

Default to hash syntax for Record&Tuple #14744

merged 2 commits into from Sep 2, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 8, 2022 •
edited by gitpod-io bot

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The proposal settled on #

cc @rricard @acutmore

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Record Tuple labels Jul 8, 2022
@nicolo-ribaudo nicolo-ribaudo added this to the 7.19.0 milestone Jul 8, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 8, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52732/

nicolo-ribaudo
nicolo-ribaudo commented Jul 8, 2022
View reviewed changes
packages/babel-generator/test/fixtures/recordAndTupleSyntaxType/missing-option/input.js Outdated
@@ -1 +0,0 @@
#{ a: 1 }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should restore this test and show that is doesn't throw anymore.

JLHwung
JLHwung approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update packages/babel-parser/typings/babel-parser.d.ts?

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jul 8, 2022
@JLHwung
Copy link
Contributor

JLHwung commented Jul 8, 2022

Can you also open a Docs PR for https://babeljs.io/docs/en/babel-parser#plugins-options?

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Sep 2, 2022
Merged
@nicolo-ribaudo nicolo-ribaudo merged commit 14ea25f into babel:main Sep 2, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the rt-syntaxtype-optional branch September 2, 2022 16:07
@shaneomatz shaneomatz mentioned this pull request Nov 18, 2022
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rricard rricard rricard approved these changes

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Record Tuple
Projects
None yet
Milestone
7.19.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicolo-ribaudo @babel-bot @JLHwung @rricard @liuxingbaoyu