New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
babel parser type improvements #14801
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52628/ |
return super.checkParams(node, allowDuplicates, isArrowFunction); | ||
return super.checkParams( | ||
node, | ||
allowDuplicates, | ||
isArrowFunction, | ||
strictModeChanged, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, interestingly - last argument was missing(comparing to overridden method signature)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Type improvements for babel parser:
...args
in class methods, replacing it with actual arguments(rebasing remaining type fixes from #13370)