Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix coverage test #14802

Merged
merged 2 commits into from Jul 27, 2022
Merged

chore: Fix coverage test #14802

merged 2 commits into from Jul 27, 2022

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Jul 26, 2022 •
edited by gitpod-io bot

Q                       A
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 26, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52638/

liuxingbaoyu
liuxingbaoyu commented Jul 26, 2022
View reviewed changes
CONTRIBUTING.md
@@ -210,8 +210,7 @@ $ OVERWRITE=true TEST_ONLY=babel-plugin-transform-classes make test-only
To test the code coverage, use:

```sh
$ BABEL_ENV=cov make build
$ ./scripts/test-cov.sh
make test-cov
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually broken because BABEL_COVERAGE=true is not set.

@JLHwung JLHwung changed the title chore: Improve test-cov chore: Fix coverage test Jul 27, 2022
@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 27, 2022
@liuxingbaoyu liuxingbaoyu merged commit a151c13 into babel:main Jul 27, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuxingbaoyu @babel-bot @existentialism @JLHwung