Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(traverse): fix some internal typescript types #14821

Merged
merged 1 commit into from Aug 3, 2022
Merged

chore(traverse): fix some internal typescript types #14821

merged 1 commit into from Aug 3, 2022

Conversation

danez
Copy link
Member

@danez danez commented Aug 2, 2022 •
edited

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change? no
Minor: New Feature? no
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes? no
License MIT

I recently fixed the types in DefinitelyTyped and found that some of the babel internal types are also not optimal. So here is a PR to fix them.

@danez danez added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: traverse area: typescript labels Aug 2, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52664/

JLHwung
JLHwung approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit a196459 into babel:main Aug 3, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danez @babel-bot @JLHwung @liuxingbaoyu @nicolo-ribaudo