Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Destructuring exceptions in nested for expressions #14841

Merged
merged 4 commits into from Aug 10, 2022
Merged

fix: Destructuring exceptions in nested for expressions #14841

merged 4 commits into from Aug 10, 2022

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Aug 10, 2022 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #14840
Patch: Bug Fix? √
Tests Added + Pass? √
License MIT

@liuxingbaoyu liuxingbaoyu added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Aug 10, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 10, 2022 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52703/

@liuxingbaoyu @JLHwung
Update packages/babel-plugin-transform-destructuring/src/util.ts
076da66 
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
@JLHwung JLHwung merged commit 614d98b into babel:main Aug 10, 2022
@liuxingbaoyu liuxingbaoyu mentioned this pull request Oct 31, 2022
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Property init of ForStatement expected node to be of a type
4 participants
@liuxingbaoyu @babel-bot @existentialism @JLHwung