Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Print build logs correctly #14846

Merged
merged 2 commits into from Aug 13, 2022
Merged

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Aug 11, 2022

Q                       A
Patch: Bug Fix?
Any Dependency Changes? removed fancy-log
License MIT

https://github.com/gulpjs/fancy-log/blob/6686d1784d11db4ccc4d91ad854e580a14ebe330/index.js#L46-L51
Since fancy-log splits a log into two prints, this can lead to confusion when multiple workers merge logs.

While this can technically be solved using readline, it is simpler and allows for more custom development in the future.

[18:58:50] Compiling './packages/babel-helpers/src/helpers-generated.ts'...
[18:58:50] Compiling './packages/babel-helpers/src/helpers/applyDecs.js'...
[18:58:50] [18:58:50] Compiling './packages/babel-helpers/src/helpers/jsx.js'...
Compiling './packages/babel-helpers/src/helpers/asyncIterator.js'...
[18:58:50] Compiling './packages/babel-helpers/src/helpers/objectSpread2.js'...
[18:58:50] Compiling './packages/babel-helpers/src/helpers/regeneratorRuntime.js'...
[18:58:50] Compiling './packages/babel-helpers/src/helpers/typeof.js'...
[18:58:50] Compiling './packages/babel-helpers/src/index.ts'...
[18:58:50] Compiling './packages/babel-node/src/_babel-node.ts'...
[18:58:50] [18:58:50] Compiling './packages/babel-highlight/src/index.ts'...
Compiling './packages/babel-helpers/src/helpers/wrapRegExp.js'...
[18:58:50] Compiling './packages/babel-node/src/babel-node.ts'...
[18:58:50] Compiling './packages/babel-parser/src/index.ts'...

@liuxingbaoyu liuxingbaoyu added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 11, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 11, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52709/

utils.js Outdated
@@ -0,0 +1,4 @@
exports.log = function log(msg, ...args) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this file to script/utils/log.cjs?

@nicolo-ribaudo nicolo-ribaudo changed the title fix: The build log is messed up fix: Print build logs correctly Aug 13, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit a32cf83 into babel:main Aug 13, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants