Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize presets before merging config with others. #9034

Merged
merged 1 commit into from Nov 17, 2018

Conversation

loganfsmyth
Copy link
Member

Q                       A
Fixed Issues? Fixes #9031
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Because we weren't normalizing this, roundtripping a config through loadOptions would re-add the plugins/preset inside env and overrides blocks, causing unexpected plugin duplication.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9395/

@loganfsmyth loganfsmyth merged commit 20a9d71 into babel:master Nov 17, 2018
@loganfsmyth loganfsmyth deleted the normalize-presets branch November 17, 2018 05:23
@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: core labels Nov 17, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested configs are not properly cleared when merging presets and options into the final config
3 participants