Fix parsing typescript function types with destructuring #9035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9401/ |
| @@ -747,6 +753,22 @@ export default (superClass: Class<Parser>): Class<Parser> => | |||
| this.next(); | |||
| return true; | |||
| } | |||
|
|
|||
| if (this.match(tt.braceL)) { | |||
| const braceStack = [tt.braceL]; | |||
There was a problem hiding this comment.
This can be an integer instead of an array, since the check only uses its length.
| const braceStack = [tt.braceL]; | ||
| this.next(); | ||
|
|
||
| while (braceStack.length > 0) { |
There was a problem hiding this comment.
Is it safe to skip the code between braces without parsing it?
e.g., wouldn't this loop accept something like {bar: {}{foo = 2=>{} }}?
There was a problem hiding this comment.
It does ignore everything, even if its invalid, but this function is only used in a lookahead() and it's job is to try to skip the first param after (.
it is used here:
and this in turn is used here:
nicolo-ribaudo
approved these changes
Nov 18, 2018
This was referenced Dec 4, 2018
Merged
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows parsing of destructured params in function type declarations.