Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recursive async function expressions #9039

Merged
merged 2 commits into from Nov 19, 2018
Merged

Fix recursive async function expressions #9039

merged 2 commits into from Nov 19, 2018

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #8783
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async Functions labels Nov 18, 2018
nicolo-ribaudo
nicolo-ribaudo commented Nov 18, 2018
View reviewed changes
...gin-transform-async-to-generator/test/fixtures/async-to-generator/named-expression/output.js
@@ -5,7 +5,9 @@ function () {
console.log(bar);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We even had a test for this 🤦‍♂️

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9405/

@nicolo-ribaudo nicolo-ribaudo merged commit c11cdcb into babel:master Nov 19, 2018
This was referenced Dec 4, 2018
Merged
Merged
Open
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@danez danez danez approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async Functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursion within async functions
4 participants
@nicolo-ribaudo @babel-bot @existentialism @danez