diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js index 84e8975e0140..7d92c3c28161 100644 --- a/packages/babel-parser/src/parser/expression.js +++ b/packages/babel-parser/src/parser/expression.js @@ -1113,11 +1113,13 @@ export default class ExpressionParser extends LValParser { ), ); - if (this.match(tt.comma) && this.lookahead().type === tt.parenR) { - this.raise( - this.state.start, - "A trailing comma is not permitted after the rest element", - ); + if (this.match(tt.comma)) { + const nextTokenType = this.lookahead().type; + const errorMessage = + nextTokenType === tt.parenR + ? "A trailing comma is not permitted after the rest element" + : "Rest parameter must be last formal parameter"; + this.raise(this.state.start, errorMessage); } break; diff --git a/packages/babel-parser/src/parser/lval.js b/packages/babel-parser/src/parser/lval.js index b9e023cbd3d2..e6c9065afdb2 100644 --- a/packages/babel-parser/src/parser/lval.js +++ b/packages/babel-parser/src/parser/lval.js @@ -258,7 +258,20 @@ export default class LValParser extends NodeUtils { break; } else if (this.match(tt.ellipsis)) { elts.push(this.parseAssignableListItemTypes(this.parseRest())); - this.expect(close); + if ( + this.state.inFunction && + this.state.inParameters && + this.match(tt.comma) + ) { + const nextTokenType = this.lookahead().type; + const errorMessage = + nextTokenType === tt.parenR + ? "A trailing comma is not permitted after the rest element" + : "Rest parameter must be last formal parameter"; + this.raise(this.state.start, errorMessage); + } else { + this.expect(close); + } break; } else { const decorators = []; diff --git a/packages/babel-parser/test/fixtures/core/uncategorised/396/options.json b/packages/babel-parser/test/fixtures/core/uncategorised/396/options.json index 570ef651fb67..b8808d8a689a 100644 --- a/packages/babel-parser/test/fixtures/core/uncategorised/396/options.json +++ b/packages/babel-parser/test/fixtures/core/uncategorised/396/options.json @@ -1,3 +1,3 @@ { - "throws": "Unexpected token, expected \")\" (1:18)" + "throws": "Rest parameter must be last formal parameter (1:18)" } diff --git a/packages/babel-parser/test/fixtures/core/uncategorised/555/input.js b/packages/babel-parser/test/fixtures/core/uncategorised/555/input.js new file mode 100644 index 000000000000..2c262ab21189 --- /dev/null +++ b/packages/babel-parser/test/fixtures/core/uncategorised/555/input.js @@ -0,0 +1,6 @@ +function foo ( + first, + ...second, + third, +) { +}; diff --git a/packages/babel-parser/test/fixtures/core/uncategorised/555/options.json b/packages/babel-parser/test/fixtures/core/uncategorised/555/options.json new file mode 100644 index 000000000000..162e897221a5 --- /dev/null +++ b/packages/babel-parser/test/fixtures/core/uncategorised/555/options.json @@ -0,0 +1,4 @@ +{ + "throws": "Rest parameter must be last formal parameter (3:13)" + } + \ No newline at end of file diff --git a/packages/babel-parser/test/fixtures/es2015/arrow-functions/comma-after-rest-param/input.js b/packages/babel-parser/test/fixtures/es2015/arrow-functions/comma-after-rest-param/input.js new file mode 100644 index 000000000000..d06c522c05b3 --- /dev/null +++ b/packages/babel-parser/test/fixtures/es2015/arrow-functions/comma-after-rest-param/input.js @@ -0,0 +1 @@ +(...rest,) => {} diff --git a/packages/babel-parser/test/fixtures/es2015/arrow-functions/comma-after-rest-param/options.json b/packages/babel-parser/test/fixtures/es2015/arrow-functions/comma-after-rest-param/options.json new file mode 100644 index 000000000000..ba0229eff23d --- /dev/null +++ b/packages/babel-parser/test/fixtures/es2015/arrow-functions/comma-after-rest-param/options.json @@ -0,0 +1,3 @@ +{ + "throws": "A trailing comma is not permitted after the rest element (1:8)" +} \ No newline at end of file diff --git a/packages/babel-parser/test/fixtures/es2015/arrow-functions/invalid-rest-in-params/input.js b/packages/babel-parser/test/fixtures/es2015/arrow-functions/invalid-rest-in-params/input.js new file mode 100644 index 000000000000..c13825de4f0a --- /dev/null +++ b/packages/babel-parser/test/fixtures/es2015/arrow-functions/invalid-rest-in-params/input.js @@ -0,0 +1,5 @@ +( + first, + ...second, + third +) => {}; diff --git a/packages/babel-parser/test/fixtures/es2015/arrow-functions/invalid-rest-in-params/options.json b/packages/babel-parser/test/fixtures/es2015/arrow-functions/invalid-rest-in-params/options.json new file mode 100644 index 000000000000..1bff860e7bc3 --- /dev/null +++ b/packages/babel-parser/test/fixtures/es2015/arrow-functions/invalid-rest-in-params/options.json @@ -0,0 +1,4 @@ +{ + "throws": "Rest parameter must be last formal parameter (3:13)" +} + \ No newline at end of file diff --git a/packages/babel-parser/test/fixtures/es2015/uncategorised/277/options.json b/packages/babel-parser/test/fixtures/es2015/uncategorised/277/options.json index 570ef651fb67..b8808d8a689a 100644 --- a/packages/babel-parser/test/fixtures/es2015/uncategorised/277/options.json +++ b/packages/babel-parser/test/fixtures/es2015/uncategorised/277/options.json @@ -1,3 +1,3 @@ { - "throws": "Unexpected token, expected \")\" (1:18)" + "throws": "Rest parameter must be last formal parameter (1:18)" } diff --git a/packages/babel-parser/test/fixtures/es2015/uncategorised/283/options.json b/packages/babel-parser/test/fixtures/es2015/uncategorised/283/options.json index 2da83bcd6f69..263bbbb08029 100644 --- a/packages/babel-parser/test/fixtures/es2015/uncategorised/283/options.json +++ b/packages/babel-parser/test/fixtures/es2015/uncategorised/283/options.json @@ -1,3 +1,3 @@ { - "throws": "Unexpected token, expected \")\" (1:5)" + "throws": "Rest parameter must be last formal parameter (1:5)" } diff --git a/packages/babel-parser/test/fixtures/esprima/es2015-arrow-function/arrow-with-multiple-rest/options.json b/packages/babel-parser/test/fixtures/esprima/es2015-arrow-function/arrow-with-multiple-rest/options.json index 2da83bcd6f69..263bbbb08029 100644 --- a/packages/babel-parser/test/fixtures/esprima/es2015-arrow-function/arrow-with-multiple-rest/options.json +++ b/packages/babel-parser/test/fixtures/esprima/es2015-arrow-function/arrow-with-multiple-rest/options.json @@ -1,3 +1,3 @@ { - "throws": "Unexpected token, expected \")\" (1:5)" + "throws": "Rest parameter must be last formal parameter (1:5)" } diff --git a/packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0258/options.json b/packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0258/options.json index 570ef651fb67..b8808d8a689a 100644 --- a/packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0258/options.json +++ b/packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0258/options.json @@ -1,3 +1,3 @@ { - "throws": "Unexpected token, expected \")\" (1:18)" + "throws": "Rest parameter must be last formal parameter (1:18)" }