Microbouji patch/8136 #9073
Merged
Microbouji patch/8136 #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of going both upwards and downwards from the first real optional expression, we can just start from the top down.
jridgewell
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9440/ |
nicolo-ribaudo
approved these changes
Nov 24, 2018
|
Are guys using VsCode when your code has optional chain syntax? How well does it work in your editor? Does it mess up editor syntax highlighting? |
This was referenced Dec 4, 2018
Merged
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
proposal-optional-chainingtransformsinto
that last
_a.b()is technically anOptionalCallExpressionwith nooptionalfield set.This PR changes it to be just a
CallExpression. I believe this is how it should be, and this also enables other plugins (liketransform-spread) who useCallExpressionin their visitors to keep working.This supersedes #8210, and fixes deeply nested optional call expressions. I've reused the original commits from that PR.