Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable #9089

Merged
merged 1 commit into from Nov 27, 2018
Merged

Remove unused variable #9089

merged 1 commit into from Nov 27, 2018

Conversation

Gcaufy
Copy link
Contributor

@Gcaufy Gcaufy commented Nov 27, 2018

When I was reading the code, I see parent is not used in _getComments function.
so it make me confused why we delivery the parent in those functions.

If I'm wrong, please correct me.

Q                       A
Major: Breaking Change? No
License MIT

When I was reading the code, I see `parent` is not used in `_getComments` function.
so it make me confused why we delivery the `parent` in those functions.

If I'm wrong, please correct me.
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9467/

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if tests are fine, lgtm, thanks

@xtuc xtuc added PR: Internal 🏠 A type of pull request used for our changelog categories PR: Polish 💅 A type of pull request used for our changelog categories pkg: generator labels Nov 27, 2018
Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you very much.

@danez danez merged commit 0047ae8 into babel:master Nov 27, 2018
@Gcaufy Gcaufy deleted the patch-1 branch November 28, 2018 02:40
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Internal 🏠 A type of pull request used for our changelog categories PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants