Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 11 to CI and remove node 9 #9096

Merged
merged 1 commit into from Nov 28, 2018
Merged

Add node 11 to CI and remove node 9 #9096

merged 1 commit into from Nov 28, 2018

Conversation

danez
Copy link
Member

@danez danez commented Nov 28, 2018

Q                       A
Fixed Issues? Fixes #8871
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Enable node 11 on circleCI.
Remove node 9 on travis and instead use node 10.
Do not cache node_modules as extracting the cache takes significant amount of time, but not sure about that, lets see what happens to build times.
Do not run yarn install twice when running tests.

This also incorporates some changes from #8871.

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 28, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 28, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9480/

@danez
Copy link
Member Author

danez commented Nov 28, 2018

It seems the regular test runs are faster now between 1 to 3 minutes each. I do not have a good explanation for this even after looking at the detailed logs. The only thing I can think of is that caching node_modules in every build was also caching node_modules/.cache which contains babel-loader, webpack, jest and potentially more caches which grow over time and it takes them longer to load? But 🤷‍♀️

@xtuc
Copy link
Member

xtuc commented Nov 28, 2018

Also we could port this webpack/webpack@edcadbb to test against any nightly.

@danez danez merged commit 6e39b58 into master Nov 28, 2018
@danez danez deleted the node-11 branch November 28, 2018 20:37
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants