Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running flow on travis and update flow #9128

Merged
merged 2 commits into from Dec 5, 2018
Merged

Fix running flow on travis and update flow #9128

merged 2 commits into from Dec 5, 2018

Conversation

danez
Copy link
Member

@danez danez commented Dec 4, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
  • ensure bootstrap is run before running flow as we need some generated files for correctly doing typechecks
  • ensure that we only ignore the build directory inside the babel folder as currently we ignore everything because travis checks out into /home/travis/build/ and .*/babel/.* matches that :)

Once the build correctly fails I will push the fixes for the types to make flow happy.

- ensure bootstrap is run before running flow as we need some generated files for correctly doing typechecks
- ensure that we only ignore the build directory inside the babel folder as currently we ignore everything because travis checks out into ‘/home/travis/build/’
@danez danez added PR: Internal 🏠 A type of pull request used for our changelog categories area: flow labels Dec 4, 2018
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 4, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9546/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So strange, I've spent a ton of time looking into this and coulda swore I've tried like a bunch of permutations of the same thing.

Glad you got it fixed tho!

@danez danez merged commit 4ca35ef into master Dec 5, 2018
@danez danez deleted the flow branch December 5, 2018 20:30
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants