Inherit properties in function from method in loose mode #9135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the class transform to inherit the properties from methods to the function that's generated in loose mode.
There was a test to ensure the return type was copied to the new function, but the
loc
of the node was lost because it was copied manually instead of usinginherits
.This is tested in
packages/babel-plugin-transform-classes/test/fixtures/loose/method-return-type-annotation
and the test keeps passing.Perhaps I should add a test for the location, but so far all tests for the package only check input/output, not the node state.