Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable parameter-destructuring in Edge 18 #9140

Merged
merged 2 commits into from Dec 7, 2018
Merged

Disable parameter-destructuring in Edge 18 #9140

merged 2 commits into from Dec 7, 2018

Conversation

saschanaz
Copy link
Contributor

Q                       A
Fixed Issues? #9139
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 7, 2018 •
edited

Could you open two separate PRs?
Also, does (param, {deep = {}}) => {} work on Edge 18?

@saschanaz
Copy link
Contributor Author

Also, does (param, {deep = {}}) => {} work on Edge 18?

Yep:

image

@saschanaz saschanaz changed the title Disable transforms for parameters/destructuring in Edge 18 Disable transforms for parameters in Edge 18 Dec 7, 2018
@saschanaz
Copy link
Contributor Author

Opened #9143.

@saschanaz saschanaz changed the title Disable transforms for parameters in Edge 18 Disable parameter-destructuring in Edge 18 Dec 7, 2018
@nicolo-ribaudo
Copy link
Member

Oh I meant one PR for the preset-env update and one for the issue message fix.

@saschanaz
Copy link
Contributor Author

Oops, okay!

@saschanaz
Copy link
Contributor Author

@nicolo-ribaudo Would you restart the test? Thanks!

existentialism
existentialism requested changes Dec 7, 2018
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschanaz thanks for the PR!

The data for preset-env is directly generated from compat-table, and support for Edge 18 data was merged ~6hrs ago.

Can you update the compat-table hash to the latest (7655c84581184806d4f94ef97fbaac7abd5852d8) in preset/env's package.json, and re-generate the data by running npm run build-data?

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Dec 7, 2018
@saschanaz
Copy link
Contributor Author

Can you update the compat-table hash to the latest

Done! Regeneration didn't cause any diffs 👍

existentialism
existentialism approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will merge after CI!

@existentialism existentialism merged commit 4dff205 into babel:master Dec 7, 2018
@existentialism
Copy link
Member

@saschanaz thanks!

@existentialism existentialism mentioned this pull request Dec 7, 2018
Closed
@saschanaz saschanaz deleted the patch-1 branch December 7, 2018 14:14
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saschanaz @nicolo-ribaudo @existentialism