New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parser] Handle flow comments with leading spaces #9168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this. There are a lot of unnecessary changes in this PR, which should be excluded please.
Also the logic does no seem to be working correctly, as the flow tests fail and also the changes committed to some of the snapshots are wrong.
packages/babel-parser/test/fixtures/core/regression/octal-float-fail/options.json
Outdated
Show resolved
Hide resolved
packages/babel-parser/test/fixtures/flow/comment/01-type-include/output.json
Outdated
Show resolved
Hide resolved
Are you planing on finishing this or otherwise I can have a look and see what is wrong? |
@danez Yeah if you could take a look I'd appreciate it, thanks. |
I leave it open for now, so we do not forget :) |
24dc6fd
to
e43c940
Compare
e43c940
to
07a417c
Compare
07a417c
to
3a34099
Compare
Thanks for fixing all the stuff, I looked into why the flow tests still failed and fixed them. |
Handle flow comments that have spaces or tabs between the end of the comment opening and the start of the flow annotation: