Fix transforming empty export statement #9171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9601/ |
| @@ -52,18 +54,7 @@ export type LocalExportMetadata = { | |||
| * Check if the module has any exports that need handling. | |||
| */ | |||
| export function hasExports(metadata: ModuleMetadata) { | |||
There was a problem hiding this comment.
Is this function still needed?
There was a problem hiding this comment.
No, but as it is a separate package I cannot remove it without breaking backwards compatibility if a mix between old and new version of Babel packages is used. At first I also wanted to use meta.hasExports directly in the transforms, but I ended up not doing it for the same reason.
nicolo-ribaudo
approved these changes
Dec 12, 2018
existentialism
approved these changes
Dec 13, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flag indicating if the module has exports and removes the current logic to detect that. This fixes the case when an export statement is present but does not really export anything:
export {}