Use injectInitialization to generate ts parameter properties
#9610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10343/ |
danez
reviewed
Feb 28, 2019
|
Since the package is a direct dependency it will always use the correct version |
danez
approved these changes
Feb 28, 2019
|
Will this land? Seems like it'll fix downstream facebook/create-react-app#5868 |
existentialism
approved these changes
May 21, 2019
nicolo-ribaudo
added
PR: Ready to be Merged
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes something where Babel is tecnically correct and
babel-plugin-istanbulis buggy, but there are an open feature request and PR to allow this behavior in TypeScript (see #9609 (comment)).I think that we can fix this in Babel.
cc @babel/typescript